Fix: Move @perstack/filesystem-storage to devDependencies#473
Merged
Conversation
The package is bundled via tsup noExternal, so it must not be listed in dependencies (which npm tries to install from the registry). Matches the pattern used for @perstack/tui-components. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@perstack/filesystem-storageis a private workspace package bundled into the CLI via tsupnoExternal(added in Fix: Bundle @perstack/filesystem-storage into CLI package #471)dependencies, causing npm to try installing it from the registry (404 since it's private)devDependenciesto match the pattern used for@perstack/tui-componentsTest plan
pnpm installsucceedspnpm run buildsucceeds inapps/perstack@perstack/filesystem-storagein dist output@perstack/tui-componentsfollows the same pattern (devDep + noExternal)🤖 Generated with Claude Code